Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: register x/authz module specific errors #11670

Merged
merged 10 commits into from
Apr 19, 2022
Merged

refactor: register x/authz module specific errors #11670

merged 10 commits into from
Apr 19, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #11577

Implement suggestion from the issue above.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Apr 18, 2022 that may be closed by this pull request
x/authz module specific errors should be registered #11577
Closed
@julienrbrt julienrbrt marked this pull request as ready for review April 18, 2022 11:26
alexanderbez
alexanderbez approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

atheeshp
atheeshp reviewed Apr 19, 2022
View reviewed changes
x/authz/msgs.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

@julienrbrt let's get the CI errors resolved (https://github.com/cosmos/cosmos-sdk/runs/6078819769?check_suite_focus=true) and we can merge this 🙌

@github-actions github-actions bot added the C:CLI label Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #11670 (e39fd84) into master (75d4e41) will increase coverage by 0.06%.
The diff coverage is 57.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11670      +/-   ##
==========================================
+ Coverage   65.84%   65.90%   +0.06%     
==========================================
  Files         667      671       +4     
  Lines       70374    70643     +269     
==========================================
+ Hits        46336    46559     +223     
- Misses      21347    21380      +33     
- Partials     2691     2704      +13
Impacted Files Coverage Δ
x/authz/keeper/msg_server.go 0.00% <0.00%> (ø)
x/authz/simulation/operations.go 66.97% <0.00%> (ø)
x/authz/msgs.go 62.09% <33.33%> (ø)
x/authz/authorization_grant.go 65.71% <50.00%> (ø)
x/staking/types/authz.go 87.37% <50.00%> (ø)
x/authz/keeper/keeper.go 70.07% <63.63%> (+0.31%) ⬆️
x/group/keeper/msg_server.go 68.35% <66.66%> (ø)
x/authz/client/testutil/tx.go 98.25% <100.00%> (ø)
x/authz/keeper/grpc_query.go 63.92% <100.00%> (ø)
x/group/keeper/invariants.go 53.62% <100.00%> (ø)
... and 7 more

@alexanderbez alexanderbez merged commit 2af642e into master Apr 19, 2022
@alexanderbez alexanderbez deleted the julien/11577-xauthz-module-specific-errors-should-be-registered branch April 19, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

Assignees

@atheeshp atheeshp

Labels
C:CLI C:Simulations C:x/authz C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/authz module specific errors should be registered
3 participants
@julienrbrt @alexanderbez @atheeshp